Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add improvements to the Module Debugger #8

Merged
merged 4 commits into from
Jun 1, 2024
Merged

Conversation

waielal
Copy link
Contributor

@waielal waielal commented May 31, 2024

  • Fix: dragging ignores scroll position
    When the module debugger is scrolled to the right and an aggregated input is resized, the selected value jumps to the left because it does not account for the scroll offset.

  • Add support for recognizing X and Z values
    Currently the module debugger assumes that all signals are 0 or 1. Verilog also works with X and Z which led to weird behavior in the debugger when outputs/wires where not driven and registers where not initialized.
    For this the value types where changed from numbers to strings and a simple upgrade method was added to convert older .dbgmodule files.

  • Add support for displaying registers and wires
    The module debugger currently lackes the ability to debug wires and registers. This PR allows registers and wires to be marked as debug and they will be shown below the outputs.
    Example:

module dff(input clk, input d, output o);
    (* lc_debug *)
    reg r = 0;
    always @(posedge clk) r <= d;
    assign o = r;
endmodule

Copy link
Owner

@lushaylabs lushaylabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is really cool, I didn't know you could $display nested wires I had been thinking that it would require a rewrite to work with VCD files for that.

I have been playing with the module debugger with your improvements and everything looks great.

You can merge this and I will create a new release.

@waielal waielal closed this May 31, 2024
@waielal
Copy link
Contributor Author

waielal commented May 31, 2024

@lushaylabs i don't have any write access to merge the RP.

@waielal waielal reopened this May 31, 2024
@lushaylabs lushaylabs merged commit 28506b8 into lushaylabs:main Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants