Sidebar #17
Sidebar #17
Conversation
|
@anotherfrontendguy can you please check this PR? I think it'd be a great addition. |
|
Thanks for your contribution. We need to provide a guide for users on how to use this component like we do for the others (see Dialog for example). Could you please provide a "maxed-out" usage example? |
|
I created an example.blade.php file inside the /components/sidebar folder. I built the sidebar almost exactly like the shadcd sidebar so you could use the documentation as reference. |
|
|
||
| $this->publishes([ | ||
| __DIR__.'/../resources/js/plugins/sidebar.js' => resource_path('js/plugins/sidebar.js'), | ||
| ], 'searchable'); |
There was a problem hiding this comment.
The second parameter should be sidebar.
| Alpine.bind(el, { | ||
| "@click"() { | ||
| this.$data.__toggle(); | ||
| console.log(this.$data.__open); |
There was a problem hiding this comment.
Drop the console.log.
There was a problem hiding this comment.
Your PR needs to be more rounded and tested. From our point of view the example doesn't work.
To test the sidebar it would be best if you provide a new repository with a fresh Laravel project that makes use of the sidebar. There you can also test and improve it.
A new feature must be realised together with documentation, which is living in this project https://github.com/luvi-ui/website.
When your sidebar is working correctly, you can create the documentation for it, like so
- create a fork from https://github.com/luvi-ui/website
- in a new branch add a section for sidebar similar to the other components
- for testing use your laravel-luvi branch in the website branch and add it under repositories (Composer repositories https://getcomposer.org/doc/05-repositories.md#vcs)
- and for the PR don't commit the composer.json with the repository
You could've provided the example in a comment here. Please remove it from this PR.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "luvi-ui/laravel-luvi", | |||
| "name": "coasterkolja/laravel-luvi", | |||
There was a problem hiding this comment.
Never change the package name
I added the Sidebar Component from shadcn/ui to luvi-ui