Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump LVGL version to 8.3.5 #67

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Bump LVGL version to 8.3.5 #67

merged 1 commit into from
Mar 7, 2023

Conversation

nia-e
Copy link
Collaborator

@nia-e nia-e commented Mar 3, 2023 •
edited
Loading

Closes #66
Remaining things to do:

  • None!

@nia-e nia-e added the enhancement New feature or request label Mar 3, 2023
This was referenced Mar 3, 2023
Closed
Merged
@nia-e
Copy link
Collaborator Author

nia-e commented Mar 4, 2023 •
edited
Loading

This is almost ready to be merged. All that's left is some mild tweaks to lvgl-codegen (it keeps spitting out warnings), removing dead code, finishing up the Style impl, and redoing examples. Other than that... I think this is ready for review?

This was a grossly overoptimistic statement.

@nia-e nia-e requested a review from rafaelcaricio March 4, 2023 14:06
nia-e
nia-e commented Mar 4, 2023
View reviewed changes
lvgl/src/lv_core/style.rs Outdated Show resolved Hide resolved
@nia-e
Copy link
Collaborator Author

nia-e commented Mar 4, 2023 •
edited
Loading

Having some trouble getting LVGL to not segfault randomly on the examples 😓 is this something you've encountered before @rafaelcaricio? Also, it seems like enabling lvgl_alloc leads to an OOM if I don't increase the memory pool (on demo, haven't tested others). I'm not entirely sure what's going on...

Seems like it was caused by the draw buffer possibly being dropped/moved. I'm quite certain that what we were doing (giving the display driver an immutable reference without even so much as a PhantomData or a Pin on the buffer when it ended up mutating the DrawBuffer pretty overtly broke Rust's aliasing rules. Thankfully this was moderately easy to debug.

@nia-e nia-e marked this pull request as ready for review March 6, 2023 17:44
@nia-e
Copy link
Collaborator Author

nia-e commented Mar 6, 2023

Done! :D I'll fix the old Gauge example (now Meter) later as that seems relatively low priority. All examples build and run as before, all tests pass. 🍾

@nia-e nia-e changed the title [WIP] Bump LVGL version to 8.3.5 Bump LVGL version to 8.3.5 Mar 6, 2023
@nia-e
Update LVGL version to 8.3.5 and rework API
86dd9ae 
bump lvgl to 8.3.5

begin fixing for 8.x

simplify style generation

rework display buffer

make lvgl_alloc build

fix tests

fix input devices
@rafaelcaricio
Copy link
Collaborator

@nia-e That is awesome! I will give a look to this PR later today. ;)

@rafaelcaricio
Copy link
Collaborator

@nia-e Feel free to merge whenever you want. Thank you! 💯

@nia-e nia-e merged commit e177b13 into master Mar 7, 2023
@rafaelcaricio rafaelcaricio deleted the lvgl-8 branch March 8, 2023 09:57
This was referenced Mar 28, 2023
Merged
Open
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelcaricio rafaelcaricio rafaelcaricio approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update LVGL to 8.x
2 participants
@nia-e @rafaelcaricio