Eliminate UB around move semantics in display logic #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelcaricio
approved these changes
Mar 27, 2023
|
Maybe we could also change the deref be ‘&mut’ instead of a owned value, then the value is not going to be dropped and we don’t need to assign it back? |
|
That should work too and would probably be cleaner, good point. I'll try that out and probably bundle that into #76 |
This was referenced Mar 28, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dereferencing of
disp_drvin display.rs:330 would lead to a move and set everything behind the old pointer to null. Simply moving back before the pointer is reused fixes this.This took at least 4 hours for me to figure out. I hate pointers.