Fixing the go1.3 compatibility issue #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
June 27, 2014 14:47
|
Many commit but these were due to me being an idiot and committing many little things such as logs for dev. Sorry for the mess guys :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After investigation this is due to the deadline set using the following line:
Line located within conn.go into the Connect proc. I guess this line is an attempt to use the timeout parameter provided by the caller and to add it to Time.Now() in order to stop dialling after the amount of seconds specified as a parameter.
I am just wondering why it has worked before unless the meaning of the SetDeadline procedure has completely been modified.
This pull request is how I would fix it. Now you can obviously decide to fix it differently.