Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support of row's color and backgroundcolor #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SuperGod
Copy link

add two function,so user can controll each row's color and background color

add two function,so user can controll each row's color and background color
@lxn
Copy link
Owner

lxn commented Nov 13, 2015

Thanks for doing this, but I would like you to make some improvements:

  • Instead of the proposed TableRow struct and the two new color setter methods, use an approach like ImageProvider, maybe call it ColorProvider.
  • This ColorProvider interface would have to be handled in reflectmodels.go, as well.
  • Also please add yourself to the AUTHORS file.

Now I regret adding the AlternatingRowBGColor stuff, when it should have been done with a ColorProvider interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants