This repository has been archived by the owner on Nov 4, 2023. It is now read-only.
Fix utf8 support for dataUri base64 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lydell
commented
Dec 27, 2019
lydell
commented
Dec 27, 2019
|
|
||
| function decodeBase64String(b64) { | ||
| if (typeof TextDecoder === "undefined" || typeof Uint8Array === "undefined") { | ||
| return atob(b64) |
There was a problem hiding this comment.
I removed the warning because I’m worried it would spam the console. I don’t think many people will end up here though.
|
@xiaoxiangmoe If this looks good to you I can merge and make a release in a couple of days. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #14. Closes #13.
@xiaoxiangmoe I failed to push to your branch so I’m opening a new PR.