fix: use correct filter for single task executions #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 67.73% 69.37% +1.64%
==========================================
Files 371 383 +12
Lines 5994 6306 +312
Branches 933 988 +55
==========================================
+ Hits 4060 4375 +315
+ Misses 1934 1931 -3
Continue to review full report at Codecov.
|
katrogan
approved these changes
Oct 9, 2020
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Oct 13, 2020
## [0.13.1](http://github.com/lyft/flyteconsole/compare/v0.13.0...v0.13.1) (2020-10-13) ### Bug Fixes * use correct filter for single task executions ([#104](http://github.com/lyft/flyteconsole/issues/104)) ([8529858](http://github.com/lyft/flyteconsole/commit/8529858abf5e67fc6b278bfd1209822671df8c11))
|
🎉 This PR is included in version 0.13.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyteorg/flyte#542
The fix for the above bug in Admin will update the filter for single task executions to be based on
task.nameinstead oflaunch_plan.name. So this PR updates the filter used inEntityDetails(in the task case) to use the new field.