fix: recompute row heights when new items are appended to DataList #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
podehnal
approved these changes
Nov 6, 2020
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Nov 6, 2020
## [0.17.1](http://github.com/lyft/flyteconsole/compare/v0.17.0...v0.17.1) (2020-11-06) ### Bug Fixes * recompute row heights when new items are appended to DataList ([#116](http://github.com/lyft/flyteconsole/issues/116)) ([04d456b](http://github.com/lyft/flyteconsole/commit/04d456b7aa4e39100955111dd803bb0d6aebc685))
|
🎉 This PR is included in version 0.17.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
When the last item in the list is larger than the default row size, appending more items to the list will cause the next item to bleed into the previously last item. This is because react-virtualized has the wrong value for the height of the row and hasn't been told to recompute it.
Note: There is no accompanying test for this change because testing the DataList component is prohibitively difficult due to the use of
CellMeasurerandAutosizerfrom thereact-virtualizedpackage. I manually verified the fix.Type
Are all requirements met?
Complete description
When starting with a list of length
n, the item at row indexn+1is our "load more" row. We use aCellMeasurerCacheto keep track of the heights of each row, and allowreact-virtualizedto computer the heights using aCellMeasurer. The starting height of the last row will be the height of our "load more" row. When we append more items, the first item in the newly-appended list will not be measured because we already have a height for it (previously computed using the "load more" row). To account for this, we are now using a layout effect that fires when the list length changes, and will force a recompute for the first item in the newly appended list if our list length is increasing.Tracking Issue
flyteorg/flyte#507
Follow-up issue
NA