fix: failed data loading/refreshing in TaskExecutionDetails #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
- Coverage 74.43% 74.32% -0.11%
==========================================
Files 415 414 -1
Lines 7310 7310
Branches 1154 1159 +5
==========================================
- Hits 5441 5433 -8
- Misses 1869 1877 +8
Continue to review full report at Codecov.
|
podehnal
approved these changes
Jan 15, 2021
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Jan 15, 2021
## [0.19.3](http://github.com/lyft/flyteconsole/compare/v0.19.2...v0.19.3) (2021-01-15) ### Bug Fixes * failed data loading/refreshing in TaskExecutionDetails ([#142](http://github.com/lyft/flyteconsole/issues/142)) ([2a3875b](http://github.com/lyft/flyteconsole/commit/2a3875bbd1bdf436cb9f5be5e1b64254f9a4536f))
13 tasks
|
🎉 This PR is included in version 0.19.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixes a failure to load data in the TaskExecutionDetails view when coming from a page where the TaskExecution has already been loaded an is in a final state.
Also fixes a refresh issue with child NodeExecutions on that page.
Type
Complete description
The
enabledflag onuseQueryis meant to delay running a dependent query until data from the parent is available. We were abusing it a little bit by attempting to use it to return cached data from a query without running the query. A better implementation of this is to conditionally set thestaleTimetoInfinityand disable refetch in the case where we want to just use whatever cached data is available. This updatesuseCondtionalQueryto follow that logic.Also fixed an issue where the NodeExecutions list on the TaskExecutionDetails page was not refreshing when the parent generator task succeeded but the spawned NodeExecutions were still in progress. This required adding a refetchInterval to the query and fixing the logic in the
shouldEnableQueryfunction.Tracking Issue
flyteorg/flyte#672