fix: polish workflow details page #215
Conversation
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
=========================================
Coverage ? 63.79%
=========================================
Files ? 361
Lines ? 7733
Branches ? 1343
=========================================
Hits ? 4933
Misses ? 2800
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
One of these changes breaks the graph; the graphing library complains it needs a width and a height. I think its because of the change on line 29.
I think we can fix it by either keeping height (and maxHeight) or alternatively we can add a container dive to ReactFlowWrapper
Signed-off-by: csirius <[email protected]> Signed-off-by: Jason Porter <[email protected]>
Signed-off-by: csirius <[email protected]> Signed-off-by: Jason Porter <[email protected]>
Signed-off-by: Jason Porter <[email protected]>
Signed-off-by: Jason Porter <[email protected]>
jsonporter
force-pushed
the
executions-versions-ui
branch
from
a5d532f to
8953f62
Compare
# [0.27.0](http://github.com/lyft/flyteconsole/compare/v0.26.0...v0.27.0) (2021-09-24) ### Bug Fixes * polish workflow details page ([#215](http://github.com/lyft/flyteconsole/issues/215)) ([dba3df1](http://github.com/lyft/flyteconsole/commit/dba3df1c5509b9a1aef7c903810551f329308631)) ### Features * add popover for bar chart item hover state ([#217](http://github.com/lyft/flyteconsole/issues/217)) ([46a7823](http://github.com/lyft/flyteconsole/commit/46a7823f785fd917f48d61e9b5dc1b81c3e3e33a))
|
🎉 This PR is included in version 0.27.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Signed-off-by: csirius [email protected]
TL;DR
Remove space between versions table and the bar chart and increase minimal height of execution list view in workflow details page.
Type
Are all requirements met?
Complete description
Tracking Issue
fixes flyteorg/flyte#1517
Follow-up issue
NA