-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update node list view and add executions bar chart #252
Conversation
Signed-off-by: csirius <[email protected]>
Signed-off-by: csirius <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
=========================================
Coverage ? 64.04%
=========================================
Files ? 370
Lines ? 8127
Branches ? 1436
=========================================
Hits ? 5205
Misses ? 2922
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the unused vars? Otherwise lgtm
Signed-off-by: csirius <[email protected]>
Signed-off-by: csirius <[email protected]>
Signed-off-by: csirius <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
# [0.36.0](http://github.com/lyft/flyteconsole/compare/v0.35.0...v0.36.0) (2021-12-15) ### Features * update node list view and add executions bar chart ([#252](http://github.com/lyft/flyteconsole/issues/252)) ([cca633e](http://github.com/lyft/flyteconsole/commit/cca633e1b597b5a4d22ba30f19d75eaf6fa3a1ff))
🎉 This PR is included in version 0.36.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
* feat: update node list view and add executions bar chart Signed-off-by: csirius <[email protected]> * fix: unit testing coverage Signed-off-by: csirius <[email protected]> * fix: remove unused vars Signed-off-by: csirius <[email protected]> * fix: show 100 executions for bar chart Signed-off-by: csirius <[email protected]> * fix: navigate to execution detail when bar chart item is clicked Signed-off-by: csirius <[email protected]>
# [0.36.0](http://github.com/lyft/flyteconsole/compare/v0.35.0...v0.36.0) (2021-12-15) ### Features * update node list view and add executions bar chart ([#252](http://github.com/lyft/flyteconsole/issues/252)) ([cca633e](http://github.com/lyft/flyteconsole/commit/cca633e1b597b5a4d22ba30f19d75eaf6fa3a1ff)) Signed-off-by: csirius <[email protected]>
Signed-off-by: csirius [email protected]
TL;DR
Update node list view according to design.
Added executions bar chart to project executions view.
Type
Are all requirements met?
Complete description
Update node list view according to design.
Added executions bar chart to project executions view.
Tracking Issue
fixes flyteorg/flyte#1911
Follow-up issue
flyteorg/flyte#1910