Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update node list view and add executions bar chart #252

Merged
merged 5 commits into from
Dec 15, 2021

Conversation

govalt
Copy link
Contributor

@govalt govalt commented Dec 8, 2021

Signed-off-by: csirius [email protected]

TL;DR

Update node list view according to design.
Added executions bar chart to project executions view.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Update node list view according to design.
Added executions bar chart to project executions view.

Tracking Issue

fixes flyteorg/flyte#1911

Follow-up issue

flyteorg/flyte#1910

@codecov
Copy link

codecov bot commented Dec 11, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@85637d5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #252   +/-   ##
=========================================
  Coverage          ?   64.04%           
=========================================
  Files             ?      370           
  Lines             ?     8127           
  Branches          ?     1436           
=========================================
  Hits              ?     5205           
  Misses            ?     2922           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85637d5...65bfafd. Read the comment docs.

Pianist038801
Pianist038801 previously approved these changes Dec 14, 2021
Copy link
Contributor

@Pianist038801 Pianist038801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jsonporter jsonporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the unused vars? Otherwise lgtm

Copy link
Contributor

@jsonporter jsonporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsonporter jsonporter merged commit cca633e into master Dec 15, 2021
@jsonporter jsonporter deleted the feat/node-list-view branch December 15, 2021 22:39
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.36.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

govalt added a commit that referenced this pull request Jan 15, 2022
* feat: update node list view and add executions bar chart

Signed-off-by: csirius <[email protected]>

* fix: unit testing coverage

Signed-off-by: csirius <[email protected]>

* fix: remove unused vars

Signed-off-by: csirius <[email protected]>

* fix: show 100 executions for bar chart

Signed-off-by: csirius <[email protected]>

* fix: navigate to execution detail when  bar chart item is clicked

Signed-off-by: csirius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add bar chart to execution details page
4 participants