feat: show details panel for failed node #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pianist038801 <[email protected]>
jsonporter
reviewed
Dec 17, 2021
| const tabState = useTabState(tabIds, tabIds.inputs); | ||
| const commonStyles = useCommonStyles(); | ||
| let tabContent: JSX.Element | null = null; | ||
| const currentNode = workflow.closure?.compiledWorkflow.primary.template.nodes.find( |
There was a problem hiding this comment.
This will only work for top-level nodes; you need to also collect nested nodes (Subworkflows, branches, dynamic, etc).
Signed-off-by: Pianist038801 <[email protected]>
Pianist038801
force-pushed
the
feat/show-detail-panel-for-failed-node
branch
from
915f60b to
9c0bac8
Compare
added 2 commits
December 21, 2021 11:54
Signed-off-by: Pianist038801 <[email protected]>
Signed-off-by: Pianist038801 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
=========================================
Coverage ? 65.01%
=========================================
Files ? 370
Lines ? 8173
Branches ? 1465
=========================================
Hits ? 5314
Misses ? 2859
Partials ? 0 Continue to review full report at Codecov.
|
Signed-off-by: Pianist038801 <[email protected]>
anrusina
reviewed
Jan 13, 2022
anrusina
reviewed
Jan 13, 2022
anrusina
reviewed
Jan 13, 2022
src/components/Executions/ExecutionDetails/NodeExecutionDetailsPanelContent.tsx
Outdated
Show resolved
Hide resolved
anrusina
reviewed
Jan 13, 2022
Signed-off-by: Pianist038801 <[email protected]>
anrusina
previously approved these changes
Jan 14, 2022
Signed-off-by: Nastya Rusina <[email protected]>
anrusina
reviewed
Jan 16, 2022
| @@ -0,0 +1,9 @@ | |||
| const path = require('path'); | |||
There was a problem hiding this comment.
anrusina
approved these changes
Jan 16, 2022
flyte-bot
added a commit
that referenced
this pull request
Jan 18, 2022
# [0.40.0](http://github.com/lyft/flyteconsole/compare/v0.39.1...v0.40.0) (2022-01-18) ### Features * show details panel for failed node ([#254](http://github.com/lyft/flyteconsole/issues/254)) ([e276493](http://github.com/lyft/flyteconsole/commit/e276493e956958a8e5858785ad5f5a4d31d5eb76))
|
🎉 This PR is included in version 0.40.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pianist038801 [email protected]
View Input & task definition of every register version directly
Type
Are all requirements met?
Tracking Issue
fixes flyteorg/flyte#1697
Follow-up issue
NA