fix: fix the crash in graph/timeline view for corner case #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nastya Rusina <[email protected]>
anrusina
requested review from
a team,
ursucarina,
jsonporter and
olga-union
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #362 +/- ##
==========================================
- Coverage 66.01% 66.00% -0.01%
==========================================
Files 402 402
Lines 8962 8964 +2
Branches 1579 1580 +1
==========================================
+ Hits 5916 5917 +1
- Misses 3046 3047 +1
Continue to review full report at Codecov.
|
EngHabu
approved these changes
Apr 8, 2022
flyte-bot
added a commit
that referenced
this pull request
Apr 8, 2022
## [0.50.1](http://github.com/lyft/flyteconsole/compare/v0.50.0...v0.50.1) (2022-04-08) ### Bug Fixes * fix the crash in graph/timeline view for corner case ([#362](http://github.com/lyft/flyteconsole/issues/362)) ([ab7340e](http://github.com/lyft/flyteconsole/commit/ab7340ebe9f5fc6e277305234cf9f6eb139035a2))
|
🎉 This PR is included in version 0.50.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nastya Rusina [email protected]
Current Graph and timeline were crashing miserably in one corner case scenario:
https://demo.nuclyde.io/console/projects/flytesnacks/domains/development/workflows/core.control_flow.subworkflows.parent_workflow?duration=all
Type
Are all requirements met?
Complete description
Ensure that the data we iterate through is accessible
Fix working video: https://share.getcloudapp.com/geumRYnA
Additional Task would be created to cover rendereing issue.