fix: on resize Header and body of the tables are mismatched #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eugene Jahn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
=======================================
Coverage 66.00% 66.01%
=======================================
Files 402 402
Lines 8964 8965 +1
Branches 1580 1580
=======================================
+ Hits 5917 5918 +1
Misses 3047 3047
Continue to review full report at Codecov.
|
anrusina
requested review from
a team,
ursucarina,
anrusina and
olga-union
and removed request for
a team
anrusina
approved these changes
Apr 10, 2022
flyte-bot
added a commit
that referenced
this pull request
Apr 10, 2022
## [0.50.4](http://github.com/lyft/flyteconsole/compare/v0.50.3...v0.50.4) (2022-04-10) ### Bug Fixes * on resize Header and body of the tables are mismatched ([#369](http://github.com/lyft/flyteconsole/issues/369)) ([5842753](http://github.com/lyft/flyteconsole/commit/5842753feabaa6398b885f90fedd6c1cfe42bd99))
|
🎉 This PR is included in version 0.50.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eugene Jahn [email protected]
fixed this issue https://github.com/flyteorg/flyteconsole/issues/318
btw. I have updated the issue to address another responsive bug for the table. It's also fixed.
Type
Are all requirements met?
Complete description
removed
flex-grow: 0andflex-shrink:0on the table column. We don't need it because we want the table to be responsive. Otherwise, can't show data in the smaller width window.also, set a minHeight for the table rows container. Otherwise, the height of the row container will be set to 0 due to auto resizer.
Tracking Issue
fixes: https://github.com/flyteorg/flyteconsole/issues/318
Follow-up issue
NA