fix: service account is not properly propagated from the execution info #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eugenejahn <[email protected]>
anrusina
reviewed
Apr 13, 2022
src/components/Executions/ExecutionDetails/ExecutionMetadataExtra.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #374 +/- ##
=======================================
Coverage 66.43% 66.44%
=======================================
Files 405 405
Lines 9060 9062 +2
Branches 1600 1602 +2
=======================================
+ Hits 6019 6021 +2
Misses 3041 3041
Continue to review full report at Codecov.
|
anrusina
requested review from
a team,
ursucarina,
anrusina and
jsonporter
and removed request for
a team
Signed-off-by: eugenejahn <[email protected]>
|
Sounds good. Updated! |
anrusina
approved these changes
Apr 13, 2022
flyte-bot
added a commit
that referenced
this pull request
Apr 13, 2022
## [0.51.2](http://github.com/lyft/flyteconsole/compare/v0.51.1...v0.51.2) (2022-04-13) ### Bug Fixes * service account is not properly propagated from the execution info ([#374](http://github.com/lyft/flyteconsole/issues/374)) ([2e250bb](http://github.com/lyft/flyteconsole/commit/2e250bb53159069bc34b8578ac53aa64334837ce))
|
🎉 This PR is included in version 0.51.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: eugenejahn [email protected]
Service account is not properly propagated from the execution info
Type
Are all requirements met?
Complete description
should fix the issue, but can't reproduce the demo bug. so not 100% sure the results. let me know if the code is not working
Tracking Issue
fixes https://github.com/flyteorg/flyteconsole/issues/372
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/