feat: add cache icons for cached tasks in graph view #400
Conversation
Signed-off-by: Olga Nad <[email protected]>
olga-union
requested review from
a team,
ursucarina,
anrusina and
jsonporter
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
==========================================
- Coverage 67.18% 67.08% -0.11%
==========================================
Files 407 407
Lines 9133 9147 +14
Branches 1609 1614 +5
==========================================
Hits 6136 6136
- Misses 2997 3011 +14
Continue to review full report at Codecov.
|
| @@ -23,7 +23,7 @@ const useStyles = makeStyles((theme: Theme) => { | |||
| position: 'relative', | |||
| }, | |||
| detailsContainer: { | |||
| alignItems: 'center', | |||
| alignItems: 'start', | |||
| if (cacheStatus === CatalogCacheStatus.CACHE_HIT) { | ||
| return <CachedOutlined style={cacheIconStyles} />; |
There was a problem hiding this comment.
nit: switch could be a better choice from readability perspective
There was a problem hiding this comment.
rewrote it in switch this morning, but then decided to use ifs 😆
| @@ -23,7 +23,7 @@ const useStyles = makeStyles((theme: Theme) => { | |||
| position: 'relative', | |||
| }, | |||
| detailsContainer: { | |||
| alignItems: 'center', | |||
| alignItems: 'start', | |||
There was a problem hiding this comment.
nit: Maybe it's only me, but I feel like icon should go 1-2 px lower, to align better with text (as it mainly uses lower case naming), plus it looks like in cases when cache icon present right margin after the icon should become smaller for 2px too.
There was a problem hiding this comment.
added 1px margin top in customNodeComponents.tsx, where the icon styles are defined
Signed-off-by: Olga Nad <[email protected]>
# [0.54.0](http://github.com/lyft/flyteconsole/compare/v0.53.0...v0.54.0) (2022-04-18) ### Features * add cache icons for cached tasks in graph view ([#400](http://github.com/lyft/flyteconsole/issues/400)) ([0c0cd4b](http://github.com/lyft/flyteconsole/commit/0c0cd4b21d621afd1465be9efbb9b21a807d5e00))
|
🎉 This PR is included in version 0.54.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Signed-off-by: Olga Nad [email protected]
Type
Are all requirements met?
Complete description
Added icons to indicate cache status of the task in graph view.
Removed unused code
components/flytegraph/Graph.tsx.Tracking Issue
fixes flyteorg/flyte#300
Follow-up issue
NA
Demo
With read from cache tasks:
With written into cache tasks:
Bonus
Fixed placement of sub headers in info section above the tabs.
Before:
After: