feat: adds more identifying information for node executions #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dynamic-task-updates #70 +/- ##
========================================================
+ Coverage 58.65% 61.50% +2.85%
========================================================
Files 363 363
Lines 5664 5669 +5
Branches 847 847
========================================================
+ Hits 3322 3487 +165
+ Misses 2342 2182 -160
Continue to review full report at Codecov.
|
schottra
force-pushed
the
remove-task-execution-rows
branch
from
a6285ef to
eea4719
Compare
BobNisco
approved these changes
May 20, 2020
.editorconfig
Outdated
Comment on lines
23
to
24
| [*.yaml] | ||
| [*.{yaml,yml}] | ||
| indent_size = 2 |
There was a problem hiding this comment.
Is there any benefit to maintaining both file-extension specific configs here and also in prettier? It looks like prettier handles more file types compared to this file, and given prettier's ability to format files on-save in an IDE, or in the pre-commit hook that's set up here, I'm not sure I understand the utility of keeping file-extension specific configs in this file.
There was a problem hiding this comment.
(The base for this PR is branched from another PR which I haven't merged yet. I did a rebase/force push/base change to avoid showing that diff here. But I'll answer the question anyway)
.editorconfig is just a convenience for people who use editors which don't support tslint. It will at least give them a better chance at getting close to our syntax without having to wait for the commit lint to yell at them.
So no it's not necessarily required. But since it's already set up, I decided to update it 😄
schottra
commented
May 20, 2020
| @@ -1,28 +1,28 @@ | |||
| { | |||
There was a problem hiding this comment.
This was a result of running yarn lint-fix manually on one of my commits, which processed all JSON files in the repo to get them in line with our prettier config :-)
schottra
added a commit
that referenced
this pull request
Jun 29, 2020
* feat: show workflow node name beneath node execution ids * feat: updating DetailsPanel info for NodeExecutions * fix lint errors * adding tests for new formatter function * test: adding new test for NodeExecutionDetails * test: adding test for new code in NodeExecutionsTable
schottra
added a commit
that referenced
this pull request
Jun 30, 2020
* feat: show workflow node name beneath node execution ids * feat: updating DetailsPanel info for NodeExecutions * fix lint errors * adding tests for new formatter function * test: adding new test for NodeExecutionDetails * test: adding test for new code in NodeExecutionsTable
schottra
added a commit
that referenced
this pull request
Jun 30, 2020
* feat: adds more identifying information for node executions (#70) * feat: show workflow node name beneath node execution ids * feat: updating DetailsPanel info for NodeExecutions * fix lint errors * adding tests for new formatter function * test: adding new test for NodeExecutionDetails * test: adding test for new code in NodeExecutionsTable * refactor: fetch child node executions for NodeExecution rows (#72) * refactor: fetch child node executions to determine expandability * fix: handling detection of children for sub-workflows as well * fix: poor performance with object-hash on some identifiers * docs: cleanup and docs for newly exposed functions * test: ensure request config is used for all levels * chore: remove unused import * feat: Remove intermediate NodeExecutionsTable row content (#75) * refactor: removing specialized rows and rendering only nodes * refactor: moving contexts up to common folder * refactor: use a data cache for nested node mapping * refactor: update loading of workflow data * fix: update usage of NodeExecutions in graph tab * fix: update TaskExecutionDetails to use data cache * fix: getting tests and stories working again * chore: docs and cleanup * test: use a more robust element query * refactor: use filter instead of reduce * docs: adding some missing function docs * fix: cleanup for dynamic tasks refactoring (#76) * test: creating dynamic task cases for NodeExecutionsTable stories * fix: styling for child group labels * fix: mock api context for NodeExecutionsTable stories * test: mock nodeExecutionData endpoint * chore: remove unused imports * fix: extract nodes from subworkflows as well * fix: adjust borders to make child groups more obvious * refactor: checkpoint for getting the nesting styles correct * refactor: adding logic for borders/spacing based on nesting/index * fix: correct workflow execution table row styles
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Jun 30, 2020
# [0.7.0](http://github.com/lyft/flyteconsole/compare/v0.6.0...v0.7.0) (2020-06-30) ### Features * improve user experience for nested NodeExecutions ([#77](http://github.com/lyft/flyteconsole/issues/77)) ([58ed1a4](http://github.com/lyft/flyteconsole/commit/58ed1a4176afeb0c13c34cf0cced13efa91ea7b4)), closes [#70](http://github.com/lyft/flyteconsole/issues/70) [#72](http://github.com/lyft/flyteconsole/issues/72) [#75](http://github.com/lyft/flyteconsole/issues/75) [#76](http://github.com/lyft/flyteconsole/issues/76)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execution Details Page