-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enables support for Blobs on the Launch form #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fast iterations! LGTM 👍
Codecov Report
@@ Coverage Diff @@
## next #86 +/- ##
==========================================
+ Coverage 63.27% 63.79% +0.52%
==========================================
Files 364 366 +2
Lines 5772 5856 +84
Branches 873 892 +19
==========================================
+ Hits 3652 3736 +84
Misses 2120 2120
Continue to review full report at Codecov.
|
* fix: show full millisecond values for subsecond durations (#81) * Bump npm from 6.14.5 to 6.14.6 (#82) Bumps [npm](https://github.com/npm/cli) from 6.14.5 to 6.14.6. - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md) - [Commits](npm/cli@v6.14.5...v6.14.6) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: show info message for un-launchable workflows (#84) * refactor: adding utility to help determine if an input type is supported * fix: adding detection and special rendering for unlaunchable workflows * fix: implementing error message for unlaunchable workflows * chore: docs * chore: pr feedback * feat: Enables support for Blobs on the Launch form (#86) * refactor: adds scaffolding for blob input support * fix: add controls and processing for blob fields * fix: support using string values for dimensionality in collections * fix: more info so validators can check subfields * test: tests for blob input helper * test: remaining tests for blobs * chore: cleanup * refactor: adding some type guards * test: fixing some test cases Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# [0.8.0](http://github.com/lyft/flyteconsole/compare/v0.7.3...v0.8.0) (2020-07-20) ### Features * 0.8.0 release ([#87](http://github.com/lyft/flyteconsole/issues/87)) ([65f2a81](http://github.com/lyft/flyteconsole/commit/65f2a8102a5cdbf2456868502dc3e7628cfc1433)), closes [#81](http://github.com/lyft/flyteconsole/issues/81) [#82](http://github.com/lyft/flyteconsole/issues/82) [#84](http://github.com/lyft/flyteconsole/issues/84) [#86](http://github.com/lyft/flyteconsole/issues/86)
flyteorg/flyte#378
This adds basic input support for blobs by rendering a micro form containing
uri
,format
anddimensionality
sub-inputs. The only required input from a user is theuri
field. Dimensionality is technically required, but is implemented with a select control that defaults to a value. So it's not possible for a user to specific an empty dimensionality in the simple case.Collections of Blobs are also supported, following the same rules as other input types (it is specified with a JSON array string). In this case, each value must include a
uri
anddimensionality
.format
is always optional and must be a string.