Use Dir instead of Base in DirectoryRefresher

[jameswang14]

DirectoryRefresher is unable to pick up updates because the condition filepath.Base(path) == d.currDir effectively is never true. I think the intention was to use filepath.Dir here instead of filepath.Base (which fetches only the last part of the path)

Tests didn't catch this issue because of the malformed conditional. The tests only used file creates, which pass because of || op == Create

[jameswang14]

👀 @gitsen

[rodaine]

Thanks for the patch! CI is failing, also there is apparently a test that covers the refreshing behavior. Can you see how the expectations there differ from yours? Could be the test is wrong.

[gitsen]

Lgtm. Thanks for the fix.
We might need to update tests.

[jameswang14]

The test didn't catch this because it only does file creates, which would pass with the old implementation because the conditional wasn't grouped correctly:

filepath.Path(path) == d.currDir && op == Write || op == Create || op == Chmod

meant that Write events would require the first condition to also be true but Creates and Chmod would always pass.

I can update tests so it also includes a Write

[jameswang14]

@rodaine I closed and re-opened the PR to rerun tests. They seem to be passing on travis-ci/pr but seems like travis-ci/push didn't update? Is there a way to rerun that? They also pass locally FWIW

EDIT: never mind didn't realize the difference between /pr and /push, but confused why one would fail and the other wouldn't in this case since there haven't been any new commits to master?

[rodaine]

LGTM. The flakiness of these tests lead me to believe there's a race in there (though not from your patch). We'll want to investigate that further.