Serialize updated at without to s #1381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MaicolBen Here is a passing version. |
|
|
MaicolBen
reviewed
Feb 28, 2020
| @@ -1,12 +1,14 @@ | |||
| module DeviseTokenAuth::Concerns::TokensSerialization | |||
| extend self | |||
| def serialize_updated_at(token) | ||
| updated_at_key = ['updated_at', :updated_at].find(&token.method(:[])) | ||
|
|
||
| if token[updated_at_key].respond_to?(:iso8601) |
There was a problem hiding this comment.
maybe we can write this better:
return token unless token[updated_at_key].respond_to?(:iso8601)
token.merge updated_at_key => token[updated_at_key].iso8601| @@ -55,16 +57,48 @@ | |||
| assert_equal(ts.dump({}), '{}') | |||
| end | |||
|
|
|||
| it 'deserialize tokens' do | |||
There was a problem hiding this comment.
why did you remove this spec? are we having breaking changes here?
| @@ -34,7 +34,7 @@ end | |||
|
|
|||
| group :test do | |||
| gem "rails-controller-testing" | |||
| gem "simplecov", require: false | |||
| gem "simplecov", "< 0.18", require: false | |||
There was a problem hiding this comment.
I don't know why this change but it's ok
There was a problem hiding this comment.
Newer simplecov is incompatible with codeclimate. codeclimate/test-reporter#413
MaicolBen
reviewed
Apr 29, 2020
|
I rebased it in #1423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project I'm on has an overridden ::Time::DATE_FORMATS[:default] that does not include the seconds in the serialized time string. This broke batch detection in a way that was very difficult to track down. This PR uses iso8601 To serialize reliably.