Users with allowed unconfirmed access can now log in successfully. #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @colavitam - thank you for sending this PR! Sorry for my late response - I'll review ASAP! |
|
Any news on this pull request? |
|
👍 |
|
I'm sorry I've been crazy busy for the past few weeks. I'll look at this tonight. |
|
+1 for this PR again. I'm having to use a forked version of the gem until it respects this option. |
|
LGTM! |
|
@colavitam - can you please resolve the conflicts (and preferably squash commits) against master? |
|
@booleanbetrayal: Should be all set! |
|
Thanks! |
booleanbetrayal
added a commit
that referenced
this pull request
Jul 3, 2015
Users with allowed unconfirmed access can now log in successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow unconfirmed users to log in, provided that the time is within the interval specified by allow_unconfirmed_access_for.