-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/i18n support #283
Feature/i18n support #283
Conversation
I created a gist with french translation : https://gist.github.com/sebfie/d1c1d94b2ebde6f8adc9 |
Thanks! I created a gist with spanish translation: https://gist.github.com/vic700208/bc86bfbb12f4f0720cd9 |
Very nice, thanks! |
This is the most comprehensive PR for localization support atm, so I'm going to close the others. Will try to take a look at in the next couple of days. In the meantime, any reason not to bundle those gists in this PR? Would be nice to get some additional validation maybe. =] @sebfie - if it's not too inconvenient, could you squash those commits? |
How can I squash this commits? I do not know how to do that. @booleanbetrayal |
here is a decent example @sebfie ... but basically you want to run Let me know if you run into any issues though. I have a preference of keeping PR merges as single commits, but if it's too troublesome, we can merge as is. |
I did it. |
969c576
to
cfac0f1
Compare
Thanks all! I'll add the other translations in a separate commit. |
Use I18n for this gem. I finished the work started by @lukaselmer in #115