Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/i18n support #283

Merged

Conversation

sebfie
Copy link

@sebfie sebfie commented Jun 30, 2015

Use I18n for this gem. I finished the work started by @lukaselmer in #115

@sebfie
Copy link
Author

sebfie commented Jun 30, 2015

I created a gist with french translation : https://gist.github.com/sebfie/d1c1d94b2ebde6f8adc9

@vic700208
Copy link

Thanks! I created a gist with spanish translation: https://gist.github.com/vic700208/bc86bfbb12f4f0720cd9

@lukaselmer
Copy link
Contributor

Very nice, thanks!

@booleanbetrayal
Copy link
Collaborator

This is the most comprehensive PR for localization support atm, so I'm going to close the others. Will try to take a look at in the next couple of days. In the meantime, any reason not to bundle those gists in this PR? Would be nice to get some additional validation maybe. =]

@sebfie - if it's not too inconvenient, could you squash those commits?

@sebfie
Copy link
Author

sebfie commented Jul 5, 2015

How can I squash this commits? I do not know how to do that. @booleanbetrayal
Yes, I can add any gist.

@booleanbetrayal
Copy link
Collaborator

here is a decent example @sebfie ... but basically you want to run git rebase -i master, mark the first commit you made as "r" (re-word), and all other commits as "f" (fixup). Save that in your editor, and it'll begin rebasing. You'll then get another editor popup for the re-word, where you can provide a comprehensive commit message. Once you're done, and you've verified everything looks good, you can push your changes with git push -f (forced push).

Let me know if you run into any issues though. I have a preference of keeping PR merges as single commits, but if it's too troublesome, we can merge as is.

@sebfie
Copy link
Author

sebfie commented Jul 8, 2015

I did it.

@sebfie sebfie force-pushed the feature/i18n_support branch from 969c576 to cfac0f1 Compare July 8, 2015 12:24
@booleanbetrayal
Copy link
Collaborator

Thanks all! I'll add the other translations in a separate commit.

booleanbetrayal added a commit that referenced this pull request Jul 8, 2015
@booleanbetrayal booleanbetrayal merged commit 658be8a into lynndylanhurley:master Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants