Don't send password reset instructions to unconfirmed email #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Background ------------------------------------------------------------------------------- Currently, we're overriding the Devise's `send_reset_password_instructions` to pass a few additional options. Problem ------------------------------------------------------------------------------- As part of this, we're also [overriding the recipient email address](https://github.com/lynndylanhurley/devise_token_auth/blob/master/app/models/devise_token_auth/concerns/user.rb#L79-L83) in order to conditionally send to the user's unconfirmed email. This is a (small) security liability. For more info see issue #287. Solution ------------------------------------------------------------------------------- We still need to override `send_reset_password_instructions`, for good reason. But we don't need to override the `to` address. We can fix the issue by eliminating those specific lines.
booleanbetrayal
added a commit
that referenced
this pull request
Jul 3, 2015
…tructions-to-unconfirmed-email Don't send password reset instructions to unconfirmed email
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently, we're overriding the Devise's
send_reset_password_instructionsto pass a few additional options.Problem
As part of this, we're also overriding the recipient email address in order to conditionally send to the user's unconfirmed email. This is a (small) security liability. For more info see issue #287.
Solution
We still need to override
send_reset_password_instructions, for good reason. But we don't need to override thetoaddress. We can fix the issue by eliminating those specific lines. Tests pass!