Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally set rails version on migration #979

Merged
merged 1 commit into from
Oct 15, 2017
Merged

Conditionally set rails version on migration #979

merged 1 commit into from
Oct 15, 2017

Conversation

MaicolBen
Copy link
Collaborator

Redone #737

@MaicolBen MaicolBen mentioned this pull request Oct 13, 2017
Closed
lynndylanhurley
lynndylanhurley approved these changes Oct 13, 2017
View reviewed changes
Copy link
Owner

@lynndylanhurley lynndylanhurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @MaicolBen + @akz92 👍

@lynndylanhurley
Copy link
Owner

oh wait it looks like a test is failing now

lynndylanhurley
lynndylanhurley requested changes Oct 13, 2017
View reviewed changes
Copy link
Owner

@lynndylanhurley lynndylanhurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is triggering an issue with the test suite

@MaicolBen MaicolBen force-pushed the conditional_migration branch from b790a52 to ac1e2bc Compare October 13, 2017 18:11
@MaicolBen MaicolBen force-pushed the conditional_migration branch from ac1e2bc to ba9b4b1 Compare October 13, 2017 18:34
@MaicolBen
Copy link
Collaborator Author

@lynndylanhurley I only cherry-picked the commit, I forgot to check if travis was passing, thanks!

@zachfeldman
Copy link
Contributor

Looks good to me if @lynndylanhurley is down to merge.

@MaicolBen MaicolBen merged commit f0e1516 into lynndylanhurley:master Oct 15, 2017
@MaicolBen MaicolBen deleted the conditional_migration branch October 15, 2017 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lynndylanhurley lynndylanhurley lynndylanhurley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaicolBen @lynndylanhurley @zachfeldman