Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie path not settable #70

Closed
andreasseiler opened this issue Nov 28, 2014 · 2 comments
Closed

Cookie path not settable #70

andreasseiler opened this issue Nov 28, 2014 · 2 comments

Comments

@andreasseiler
Copy link

Hi there,

first of all thanks for your hard work!

Recently I stumbled across the following issue angular/angular.js#1786

The following branch seems to "fix" this issue. At least it shows an easy way to avoid it :) Maybe it's possible to expose the path option to the submitLogin function?

m2omou@6d70d76

Just an idea, I haven't thought it through regarding the impact it has ;)

Regards,
Andi

@lynndylanhurley
Copy link
Owner

Hi @andreasseiler - that branch has been merged for some time.

If I remember correctly, the issue is that it's impossible to control the cookie's path value when using the ngCookie module, and it was resulting in duplicate auth cookies.

The solution was to use the ipCookie module instead, and to force the cookie to use the root path of the domain (/).

Just to clarify, are you suggesting that this module should expose a param for setting custom auth cookie paths?

@lynndylanhurley
Copy link
Owner

@andreasseiler - I'll need more clarification on this issue. Please re-open if you're still having trouble.

nbrustein pushed a commit to nbrustein/ng-token-auth that referenced this issue May 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants