-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/templates from server #12
Open
Seboran
wants to merge
5
commits into
lyonjs:main
Choose a base branch
from
Seboran:feat/templates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Seboran
force-pushed
the
feat/templates
branch
from
October 26, 2024 07:47
deae096
to
a3d951a
Compare
Seboran
force-pushed
the
feat/templates
branch
from
October 26, 2024 08:12
a3d951a
to
583e360
Compare
Seboran
force-pushed
the
feat/templates
branch
from
October 27, 2024 15:10
01c4165
to
5d5e4ef
Compare
Seboran
force-pushed
the
feat/templates
branch
from
October 29, 2024 18:43
5d5e4ef
to
7a0d660
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what does this PR do?
live templates loading from appwrite
you can test here: https://code-in-the-dark-editor-git-feat-templates-seborans-projects.vercel.app/compete
How does it work?
Set an appwrite collection with every attributes implementing
TemplateInformations
interface:Created
fetchTemplates.ts
which plugs to appwrite in server side.Long pooling using SWR.
page previews are hosted in an appwrite bucket to keep them hidden.
I don't think we should move the other images and logos because we it makes relative URLs simpler
New env variables
You need to set 4 new environments variables:
Some ideas and questions
Thinking about this point, at the very worst we would have 8 participants long pooling every 2 seconds during 5 minutes, which would amount to 1200 requests, don't think it would make a huge impact
pnpm-lock.yml
changes 🙈