Small fixes, removing blockers. #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new metric to count timeouts.
Pull Request Test Coverage Report for Build 1011
💛 - Coveralls |
yachang
suggested changes
Sep 20, 2019
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @pboothe and @yachang)
ndt5/web100/web100_linux.go, line 18 at r1 (raw file):
return nil, errors.New("zero-length list of data collected") } sumrtt := uint32(0)
Add doc here for those variables, since you do divided by 1000 in the following code.
yachang
suggested changes
Sep 20, 2019
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @pboothe and @yachang)
ndt5/s2c/s2c.go, line 122 at r1 (raw file):
warnonerror.Close(testConn, "Could not close testConnection") bps := 8 * float64(byteCount) / record.EndTime.Sub(record.StartTime).Seconds()
Add doc here? Why it was 10 previously?
yachang
reviewed
Sep 20, 2019
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @pboothe)
yachang
approved these changes
Sep 20, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @pboothe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the UUID to the output.
Improve logging and fix some log spam.
Add fields to web100.
Part of #185, #161, #159, https://github.com/m-lab/dev-tracker/issues/412, https://github.com/m-lab/dev-tracker/issues/329
This change is