-
Notifications
You must be signed in to change notification settings - Fork 163
Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -125,14 +125,6 @@ macro_rules! if_alloc { | |
)*) | ||
} | ||
|
||
#[allow(unused)] | ||
macro_rules! if_endian_fd { | ||
($($i:item)*) => ($( | ||
#[cfg(feature = "endian_fd")] | ||
$i | ||
)*) | ||
} | ||
|
||
#[cfg(feature = "alloc")] | ||
pub mod error; | ||
|
||
|
@@ -222,6 +214,13 @@ pub mod container { | |
} | ||
} | ||
|
||
macro_rules! if_endian_fd { | ||
($($i:item)*) => ($( | ||
#[cfg(all(feature = "endian_fd", feature = "elf64", feature = "elf32", feature = "pe64", feature = "pe32", feature = "mach64", feature = "mach32", feature = "archive"))] | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
philipc
Author
Collaborator
|
||
$i | ||
)*) | ||
} | ||
|
||
if_endian_fd! { | ||
|
||
#[derive(Debug, Default)] | ||
|
1 comment
on commit b864469
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. No let’s make the hints require parser. That’s what they’re for primarily
I’m thinking about moving hint + object into an object module and reexport it but can worry about it later.
This still isn’t right i think.
It means in order to use the parse functions in the elf module you have to also have enabled PE, etc. whereas before you could enable the endian ELF parser and not have mach or PE enabled.
I think this union of features only ever applies to the
goblin::Object
and its impl block.