changelog: update changelog; add fixme about parsing strictness

m4b · Jan 28, 2018 · e76101f · e76101f
1 parent 7a8f265
commit e76101f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@ I'm sorry, I will try my best to ease breaking changes.  We're almost to 1.0, do
 ## [Unreleased]
 ### Changed
 ### Added
+ - mach.segments: do not panic on bad internal data bounds: https://github.com/m4b/goblin/issues/74
  - mach: correctly add weak dylibs to import libs: https://github.com/m4b/goblin/issues/73
 
 ## [0.0.14] - 2018-1-15

diff --git a/src/mach/mod.rs b/src/mach/mod.rs
@@ -159,6 +159,7 @@ impl<'a> MachO<'a> {
             debug!("{} - {:?}", i, cmd);
             match cmd.command {
                 load_command::CommandVariant::Segment32(command) => {
+                    // FIXME: we may want to be less strict about failure here, and just return an empty segment to allow parsing to continue?
                     segments.push(segment::Segment::from_32(bytes, &command, cmd.offset, ctx)?)
                 },
                 load_command::CommandVariant::Segment64(command) => {