Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elf: Non-alloc ProgramHeader exposes impl. #308

Merged
merged 1 commit into from
May 28, 2022
Merged

Conversation

dancrossnyc
Copy link
Contributor

  • Expose more of the ProgramHeader implementation regardless
    of whether the alloc feature is enabled. For example,
    ProgramHeader::from_raw_parts is a wrapper around
    core::slice::from_raw_parts that has alloc dependency.
  • Run cargo fmt.

Based on an internal patch by Keith Wesolowski (@wesolows).

Signed-off-by: Dan Cross [email protected]

* Expose more of the `ProgramHeader` implementation regardless
  of whether the `alloc` feature is enabled.  For example,
  `ProgramHeader::from_raw_parts` is a wrapper around
  `core::slice::from_raw_parts` that has `alloc` dependency.
* Run `cargo fmt`.

Based on an internal patch by Keith Wesolowski (@wesolows).

Signed-off-by: Dan Cross <[email protected]>
@dancrossnyc
Copy link
Contributor Author

This is really #305, which I accidentally closed but could not get to reopen. Sigh.

Copy link
Owner

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@m4b m4b merged commit 8788991 into m4b:master May 28, 2022
@dancrossnyc dancrossnyc deleted the phimpl branch June 2, 2022 19:30
@m4b
Copy link
Owner

m4b commented Jun 6, 2022

ok released in 0.5.2, thanks for your help!

@dancrossnyc
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants