Remove check on debug directory size #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The well intentioned check on debug directory size unfortunately results in an error when debug information is embedded in the image. Tools like Digital Mars embed CV debug info in the image instead of creating a PDB, and some older tools embed COFF debug info in the image.
m4b
reviewed
Jun 3, 2022
| @@ -150,8 +150,8 @@ impl<'a> CodeviewPDB70DebugInfo<'a> { | |||
|
|
|||
| // calculate how long the eventual filename will be, which doubles as a check of the record size | |||
| let filename_length = idd.size_of_data as isize - 24; | |||
| if filename_length < 0 || filename_length > 1024 { | |||
| // the record is too short or too long to be plausible | |||
| if filename_length < 0 { | |||
There was a problem hiding this comment.
Is there no maximum bound to check against ? (Worried about regressions if removing this)
also curious the number 1024 was used, I wonder why that was chosen ? (Haven’t looked at this code in a while)
There was a problem hiding this comment.
1024 is an odd choice - MAX_PATH + some small constant factor (to include the hash and other data in the section) seems reasonable, but 1024 is a bit bigger than I'd expect for the typical size of the directory.
That said, I don't think there is a maximum bound - and as this crate is typically used, the memory is already mapped/allocated, so it's mostly harmless to remove the check.
m4b
approved these changes
Jun 5, 2022
|
@lzybkr thank you! |
|
ok released in 0.5.2, thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The well intentioned check on debug directory size unfortunately results
in an error when debug information is embedded in the image.
Tools like Digital Mars embed CV debug info in the image instead of
creating a PDB, and some older tools embed COFF debug info in the image.