Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mach: Implement LC_BUILD_VERSION #341

Merged
merged 1 commit into from
Nov 6, 2022
Merged

mach: Implement LC_BUILD_VERSION #341

merged 1 commit into from
Nov 6, 2022

Conversation

messense
Copy link
Contributor

@messense messense commented Nov 5, 2022

Closes #255

messense
messense commented Nov 5, 2022
View reviewed changes
src/mach/load_command.rs
pub const PLATFORM_IOSSIMULATOR: u32 = 7;
pub const PLATFORM_TVOSSIMULATOR: u32 = 8;
pub const PLATFORM_WATCHOSSIMULATOR: u32 = 9;
pub const PLATFORM_DRIVERKIT: u32 = 10;
Copy link
Contributor Author

@messense messense Nov 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLATFORM_* consts come from https://github.com/apple-oss-distributions/dyld/blob/c8a445f88f9fc1713db34674e79b00e30723e79d/common/MachOFile.h#L111-L124

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thank you!

@messense messense mentioned this pull request Nov 5, 2022
Closed
m4b
m4b approved these changes Nov 6, 2022
View reviewed changes
Copy link
Owner

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for implementing this!

src/mach/load_command.rs
@@ -1610,9 +1657,8 @@ impl<'a> ctx::TryFromCtx<'a, Endian> for CommandVariant {
let comm = bytes.pread_with::<LinkeditDataCommand>(0, le)?;
Ok((DyldChainedFixups(comm), size))
}
// TODO: LC_NOTE (NoteCommand) and LC_BUILD_VERSION (BuildVersionCommand)
// are unimplemented.
LC_NOTE | LC_BUILD_VERSION | _ => Ok((Unimplemented(lc), size)),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for implementing this!

src/mach/load_command.rs Show resolved Hide resolved
@m4b
Copy link
Owner

m4b commented Nov 6, 2022

Just had the one question about method, otherwise lgtm

@m4b m4b merged commit c81ebdb into m4b:master Nov 6, 2022
@m4b
Copy link
Owner

m4b commented Nov 6, 2022

thanks @messense ! do you need a point release for this soon or it's ok to wait a bit and collect some other PRs?

@messense messense deleted the macho-build-version branch November 6, 2022 06:33
@messense
Copy link
Contributor Author

messense commented Nov 6, 2022

It's ok to wait for a while.

@messense messense mentioned this pull request Nov 19, 2022
Merged
@messense
Copy link
Contributor Author

messense commented Feb 9, 2023

Hi @m4b, do you plan to release a new version soon? I'd like to use this for PyO3/maturin#1252, thanks!

@m4b
Copy link
Owner

m4b commented Feb 25, 2023

@messense sorry for delay life was busy, do you also need #342 ? I was considering branching and cherry-picking the non-breaking changes and delaying 342 until another breaking change? But if you need it can just release all at once in 0.7

@messense
Copy link
Contributor Author

I dont need it.

m4b pushed a commit that referenced this pull request Feb 26, 2023
@messense @m4b
mach: Implement LC_BUILD_VERSION (#341)
89b2abe
@m4b
Copy link
Owner

m4b commented Feb 26, 2023

@messense published all non-breaking changes as 0.6.1, and new 0.6.1 branch along with git tag, thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4b m4b m4b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mach: Implement LC_BUILD_VERSION
2 participants
@messense @m4b