Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test timers #2

Merged
merged 10 commits into from
Nov 13, 2023
Merged

Test timers #2

merged 10 commits into from
Nov 13, 2023

Conversation

maanst
Copy link
Owner

@maanst maanst commented Nov 13, 2023

The order of the tests is unclear to me. Changes I have done in the code are not reflected in the workflow runs. Trying to merge this branch into the main to see if anything changes.

@maanst maanst merged commit 26853a5 into main Nov 13, 2023
@maanst maanst deleted the test_timers branch November 13, 2023 13:11
@matuskalas
Copy link

Were the changes reflected after you merged this into main?

@maanst
Copy link
Owner Author

maanst commented Nov 15, 2023

I'm a little unsure of what you mean. There might be some weird artifacts since I squashed and merged. I did this because there were many trials and errors before I figured out the problem with the hardcoded repo reference in the yamls.

@maanst
Copy link
Owner Author

maanst commented Nov 15, 2023

The order of the tests is unclear to me. Changes I have done in the code are not reflected in the workflow runs. Trying to merge this branch into the main to see if anything changes

This problem was fixed when I changed the actions/checkout to use default repo where the workflow has been started from and not the hardcoded edamontology/caseologue :)

@matuskalas
Copy link

Ok, perfect👍🏽 That's what I hoped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants