perf: remove usage of named attribute accesses on bunches #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of at runtime, which gives a runtime overhead.
this has a runtime overhead (about 20% faster without it)
for more information, see https://pre-commit.ci
|
Cool! You can also open a PR on the traitlets repo, and once my branch is merged you can rebase. |
maartenbreddels
force-pushed
the
perf_construction
branch
2 times, most recently
from
4324bbb to
1c85d41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the investigation in this comment, this PR removes any usage of
bunch.namewithin traitlets. It's about a 12 character change in total, but for some specific (extremely artificial) benchmarks that have a lot of value changes + some observers on a traitlet, you can get a modest reduction in runtime.This PR is totally backwards compatible: it does not change the Bunch interface. It just uses bunches differently internally for a free performance benefits.
I can update this PR to the main branch on the traitlets repo once ipython#777 is merged :-)