Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using sales invoice custom fields #59

Merged
merged 6 commits into from
Jan 6, 2021
Merged

Fix using sales invoice custom fields #59

merged 6 commits into from
Jan 6, 2021

Conversation

benjaminwols
Copy link
Contributor

Moneybird has changed the way custom_fields are used
This PR adds a custom_field resource the same way as event/detail is used

Changelog 09-08-2019

The custom_fields_attributes and details_attributes fields are now all consistent with each other. This simplifies the mapping of there between different endpoints. It has changed from custom_fields_attributes[*][id] to custom_fields_attributes[id].

@maartenvanvliet
Copy link
Owner

👍
Just curious, are you using the gem anywhere (in production)?

@maartenvanvliet maartenvanvliet merged commit a8ace06 into maartenvanvliet:master Jan 6, 2021
@benjaminwols benjaminwols deleted the fix-using-sales-invoice-custom-fields branch January 6, 2021 13:21
@benjaminwols
Copy link
Contributor Author

Not yet, but we are integrating at the moment and are planning to use it in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants