-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test deprecations #60
Fix test deprecations #60
Conversation
This reverts commit 357ab6e.
@maartenvanvliet I've updated the Readme badge to Github Actions and removed the deprecated code climate gem and updated Github actions to push coverage to code climate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't say I'm a fan of the _(...).must_equal
syntax, and would probably prefer plain assert_equal
assertions over this. But the library already uses specs and this is the new way so 🤷
Thanks for fixing it all up!
Co-authored-by: Maarten van Vliet <[email protected]>
Minitest has new syntax which showed a lot of deprecation warnings in the test suite.
This PR converts to the new syntax.