Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test deprecations #60

Merged
merged 14 commits into from
Jan 16, 2021
Merged

Fix test deprecations #60

merged 14 commits into from
Jan 16, 2021

Conversation

benjaminwols
Copy link
Contributor

Minitest has new syntax which showed a lot of deprecation warnings in the test suite.
This PR converts to the new syntax.

@benjaminwols
Copy link
Contributor Author

@maartenvanvliet I've updated the Readme badge to Github Actions and removed the deprecated code climate gem and updated Github actions to push coverage to code climate

Copy link
Owner

@maartenvanvliet maartenvanvliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I'm a fan of the _(...).must_equal syntax, and would probably prefer plain assert_equal assertions over this. But the library already uses specs and this is the new way so 🤷

Thanks for fixing it all up!

Co-authored-by: Maarten van Vliet <[email protected]>
@maartenvanvliet maartenvanvliet merged commit 76ec084 into maartenvanvliet:master Jan 16, 2021
@benjaminwols benjaminwols deleted the fix-test-deprecations branch January 19, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants