Enhance UX for the browser action, possibility to disable popup #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's done, I tested edge cases too, like when you have selected trace, then go to options, you disable popup and then click on icon, so in this case will be disabled. I tested keyboard shortcuts too. I will test it again tomorrow and this PR will be ready, pls look at it and give some feedback, thx. |
|
Tested again today and every thing looks good 🏠 |
silverqx
changed the title
|
Can confirm it works great for me. Just what I was looking for after switching to Vivaldi, and here it is already done! Hope it gets merged into the master branch! |
|
Thanks for the reminder, I should really merge and release this. I will hit the merge button right now, and try to release it asap. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added possibility to enable / disable XDebug Session only by left click on xdebug helper icon.