Merge pull request #807 from macbre/improved-error-handling

bin/phantomas.js should output Browser.visit() promise rejections to stderr
macbre · Oct 26, 2020 · 0ebdfd7 · 0ebdfd7
2 parents 853a293 + e3d7f73
commit 0ebdfd7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -35,3 +35,6 @@ jobs:
 
     - name: Check that bin/phantomas.js works
       run: ./bin/phantomas.js http://127.0.0.1:8888/ --pretty | grep "generator" -A4
+
+    - name: Check that bin/phantomas.js handles errors correctly
+      run: ./bin/phantomas.js http://127.0.0.1:1234/ 2>&1 | grep "net::ERR_CONNECTION_REFUSED at http://127.0.0.1:1234"
diff --git a/bin/phantomas.js b/bin/phantomas.js
@@ -198,7 +198,8 @@ if (!process.stdout.isTTY && options.colors !== true) {
 phantomas(url, options)
   .catch((err) => {
     debug("Error: %s", err);
-    process.exit(1);
+    console.error("" + err);
+    process.exit(2);
   })
   .then(async (results) => {
     debug("Calling a reporter...");

diff --git a/lib/index.js b/lib/index.js
@@ -187,6 +187,9 @@ function phantomas(url, opts) {
 
       resolve(results);
     } catch (ex) {
+      debug("Exception caught: " + ex);
+      debug(ex);
+
       // close the browser before leaving here, otherwise subsequent instances will have problems
       await browser.close();
       reject(ex);