Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete line action, plus undo implemented for various commands #180

Merged
merged 64 commits into from
Jun 1, 2024
Merged

Delete line action, plus undo implemented for various commands #180

merged 64 commits into from
Jun 1, 2024

Conversation

machinewrapped
Copy link
Owner

  • Added delete line command, with an undo option.
  • Implemented undo stack.
  • Added support for multiple viewmodel updates in a command.
  • Fixed the viewmodel updates for several commands.
  • Implemented undo for several commands.
  • Use queued connections as much as possible to reduce deadlock danger

@machinewrapped
Provisional delete lines command
e411d2e
@machinewrapped
Undo stack
7041afd
@machinewrapped
Type hints
5364aaa
@machinewrapped
Return valid type when deletion fails
885d5be
@machinewrapped
Reset selection when lines are deleted
7def0e6 
This should really be handled by the model, but the relevant events and signals don't seem to arrive at the SubtitleView.
@machinewrapped
Use queued connections as much as possible
6a519b2
@machinewrapped
Undo for merge lines
c313c49
@machinewrapped
Allow multiple model updates per command
34c1167
@machinewrapped
Undo for split/merge scene commands
fe45704
@machinewrapped
Fix undo for merge scenes
b4957e3
@machinewrapped
Fix for undo merge scenes
d09f4ec
@machinewrapped
More precise viewmodel update for line merge
6bd403f
@machinewrapped
Display subtitle line number in debugger
fb46ffc
@machinewrapped
Fix for undo merge batches
258b728
@machinewrapped
Rename Reset -> Clear
8ec7399
@machinewrapped
Only write project after batching if the flag is set
dd3c95f
@machinewrapped
Allow merging a single line without exception
a0adfeb 
... it makes unit testing easier, even if it is a pointless operation.
@machinewrapped
Unit tests for merge commands + undo
5262be1
@machinewrapped
Merge branch 'main' into delete-line
d79379e
@machinewrapped
Debug repr
64fdbf4
@machinewrapped
Moved batch settings back into test case
ff3f48e
@machinewrapped
Split scene test
1b103e5
@machinewrapped
Rename test file/class
9c1c91e
@machinewrapped
Fix for split batch undo
c4c85f2
@machinewrapped
Test for SplitBatchCommand
c10b1b9
@machinewrapped
Undo for AutoSplitBatchCommand + tests
913130f
@machinewrapped
Just pass line numbers to MergeLinesCommand
7b685c5 
plus return true for undo.
@machinewrapped
Merge lines test
41faf35
@machinewrapped
Removed obsolete import
bfc0b8a
@machinewrapped
Redo commands
709e4d2
@machinewrapped
More delete tests
8d385a1
@machinewrapped
Separate test for batching
03c9df5
@machinewrapped
Cleanup
9b86053
@machinewrapped
Consolidate options in base class
175e029
@machinewrapped
Reparse translations tests
5804dd9
@machinewrapped
Made can_undo true by default
8908be1
@machinewrapped
Don't renumber everything on save
89de309 
... I more or less trust the app not to mess up numbering now, so it shouldn't need forcing correct too often (can always reload the project)
@machinewrapped
Removed some dead lines
ea0f10f
@machinewrapped
Undo for reparse translations
ecaff61 
+ selective line reparse and test fix
@machinewrapped
Fixed undo for reparse translations
69c9811 
+ save minimal undo data
@machinewrapped
Update undo/redo tooltips
b270e53
@machinewrapped
Clear the undo stack when a command can't be undone
50a530a
@machinewrapped
Restore summaries on undo merge batches
20564d0
@machinewrapped
Restore summaries on undo merge scenes
1ff5ecc
@machinewrapped
Fix for undo delete lines
0096841
@machinewrapped
Don't save project file automatically after reparse
114354c
@machinewrapped
Try to update proxy model when underlying model changes
ca4684c
@machinewrapped
Don't modify parser translated when matching to originals
3feaa9b
@machinewrapped
Don't renumber lines on load either
428e158 
Reparse translation doesn't go well if the line numbers change
@machinewrapped
Don't renumber lines on post-process
c2e9d35 
Note: this also implies that we can never implement line split
@machinewrapped
Update a TODO
8270652
@machinewrapped
Ensure scenes and batches are numbered correctly
17d82ed
@machinewrapped
Fix merging/preserving line translations
70f95e2
@machinewrapped
Fix merge test logs
d208d52
@machinewrapped
Validate merged translations
4a9581c
@machinewrapped
Undid -> Undone
7b3ded4
@machinewrapped
Make InsertLines do what it says
9b56755 
It may be inefficient but better than being surprising
@machinewrapped
Copy link
Owner Author

  • Added delete line command, with an undo option.
  • Implemented undo stack.
  • Added support for multiple viewmodel updates in a command.
  • Fixed the viewmodel updates for several commands.
  • Implemented undo for several commands.
  • Use queued connections as much as possible to reduce deadlock danger
  • Prevent renumbering of lines except when writing translated subs, so that reparse translation doesn't overwrite the wrong lines
  • Unit tests for all commands that support undo

@machinewrapped machinewrapped merged commit c06731d into main Jun 1, 2024
@machinewrapped machinewrapped deleted the delete-line branch June 1, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@machinewrapped