Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement modern sqlite support (e.g. windows, aggregates) #70

Closed
machow opened this issue Jun 7, 2019 · 3 comments
Closed

implement modern sqlite support (e.g. windows, aggregates) #70

machow opened this issue Jun 7, 2019 · 3 comments
Labels
be:sql be:sqlite .epic High level collection of issues, which enable something useful.

Comments

@machow
Copy link
Owner

machow commented Jun 7, 2019

tbl_mtcars >> filter(_.mpg > _.mpg.mean())
@machow machow added the be:sql label Jun 21, 2019
@machow machow added this to siuba Jan 6, 2022
@machow machow changed the title sqlite should be able to use aggregates in an ungrouped filter implement modern sqlite support (e.g. windows, aggregates) Jan 11, 2022
@machow
Copy link
Owner Author

machow commented Jan 11, 2022

Note that in general sqlite has a good support for afaik windows and aggregates these days, so changing issue to focus on that

@machow machow added .epic High level collection of issues, which enable something useful. be:sqlite labels Jan 11, 2022
@machow
Copy link
Owner Author

machow commented Mar 23, 2022

Support for window functions was added 4 years ago, so it is likely safe to just add everything into the current sqlite dialect (note that dbplyr checks the sqlite version before selecting the right sqlite dialect)

https://www.sqlite.org/changes.html

image

@machow
Copy link
Owner Author

machow commented Mar 29, 2022

Resolved by #406

@machow machow closed this as completed Mar 29, 2022
@machow machow moved this to Done in siuba Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
be:sql be:sqlite .epic High level collection of issues, which enable something useful.
Projects
Status: Done
Development

No branches or pull requests

1 participant