Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sqlite window functions #406

Merged
merged 11 commits into from
Mar 29, 2022
Merged

feat: support sqlite window functions #406

merged 11 commits into from
Mar 29, 2022

Conversation

machow
Copy link
Owner

@machow machow commented Mar 24, 2022

This PR does the following:

  • implements window functions (which sqlite started supporting a few years ago)
    • includes dply vector functions. E.g. dense_rank()
  • implements some aggs which I thought sqlite didn't support (e.g. n())
  • remove most cases of skipping sqlite from unit tests!
  • fixes failing bigquery tests (that were accidentally skipped on CI)

@machow machow marked this pull request as ready for review March 29, 2022 01:45
@machow machow force-pushed the feat-sqlite-dialect branch from c6dfb05 to 5755ba9 Compare March 29, 2022 01:45
@machow machow changed the title draft: initial sqlite window functions feat: support sqlite window functions Mar 29, 2022
@machow machow merged commit b284d75 into main Mar 29, 2022
@machow machow deleted the feat-sqlite-dialect branch March 29, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant