fix: allow piping symbolic attributes like _.a #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #324, by stripping symbolics from calls like
pipe(_.a). While I'm at it, I'll add a few more tests of Pipeable later today, then merge!This PR also fixes support for slicing. See #324 for full details. The crux is that symbolic handling for multiple slices was broken.
output:
It fixes by adding two classes corresponding to how the python AST represents slicing, _SliceOpIndex and _SliceOpExt, and registers them on a factory class, SliceOp. This could probably be simplified in the future..!