better lookup for _schema_name #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for the patch! What issue in particular does it solve?
sob., 19 gru 2020, 17:28 użytkownik Domenico <[email protected]>
napisał:
… try to find "_schema_name" both in task.request.headers and task.request.
------------------------------
You can view, comment on, or merge this pull request online at:
#47
Commit Summary
- check _schema_name
File Changes
- *M* tenant_schemas_celery/app.py
<https://github.com/maciej-gol/tenant-schemas-celery/pull/47/files#diff-88c067b7010acb0a33d6d34761df75cdd9756a48660eb8b3ebe4ab5aae00fc4e>
(5)
Patch Links:
- https://github.com/maciej-gol/tenant-schemas-celery/pull/47.patch
- https://github.com/maciej-gol/tenant-schemas-celery/pull/47.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#47>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOGQTLQNQPGTPNW2B5KQR3SVTID3ANCNFSM4VCM2EUA>
.
|
|
Hi @maciej-gol , Basically I find the request.task.header set (with sentry headers), so it will ignore request.task, where my "_schema_name" key is. |
|
What celery version you are using?
niedz., 20 gru 2020, 17:17 użytkownik Domenico <[email protected]>
napisał:
… Hi @maciej-gol <https://github.com/maciej-gol> ,
This is the issue.
#46 <#46>
Basically I find the request.task.header set (with sentry headers), so it
will ignore request.task, where my "_schema_name" key is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOGQTJGXQDZFYEDJHKACYDSVYPR3ANCNFSM4VCM2EUA>
.
|
|
celery==4.3.0 I also tried with different version of tenant-schemas-celery |
|
Thanks for the report! Im currently away from my personal computer, and
will be able to look into early January. Unfortunately.
niedz., 20 gru 2020, 21:36 użytkownik Domenico <[email protected]>
napisał:
… celery==4.3.0
django-celery-beat==1.5.0
django-celery-email==2.0.2
django-celery-results==1.1.2
tenant-schemas-celery==0.2.1
sentry-sdk==0.19.1
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOGQTPRVABMLJH5QLIASHLSVZN3DANCNFSM4VCM2EUA>
.
|
|
no problem, let's look at it in Jan! Enjoy your holidays :) |
maciej-gol
reviewed
Jan 2, 2021
|
Also, please rebase on the newest |
Co-authored-by: Maciej Gol <[email protected]>
addressed! |
|
Thanks! Should release a new version soon, most likely today. |
much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try to find "_schema_name" both in task.request.headers and request.task
address #46