Add support for django with multiple databases #53
Conversation
This allows to switch schema for all connections rather than the only default database. The changes assume that all connections are always on the same schema as the first connection (`'default'`), meaning the tasks are not switching schema during their execution. Thus that we don't need to check all connections whether they are on a different schema or not. The lines where the assumption is made: - app.py:33 - app.py:39 - app.py:42 - app.py:46 - app.py:65
Django 4.0 dropped `django.conf.urls.url()` for `django.urls.re_path()`
|
Hey, @NyanKiyoshi! Thanks for this MR! The changes look very good. Could you please add tests coverage, too? Also, this is not a backwards-compatible change. Could you please add a settings to control this behavior? We could make it a list of db names defaulting to |
Hi @maciej-gol, Great suggestion! I pushed 127b266 with the requested changes. If it looks good, then I will update the readme file as well to reflect the changes. Do note that in the test case But I do believe the test case is enough, I added Second, I did not add Let me know your feedbacks |
|
Thanks for this improvement! Everything looks sound! Also, thanks for explaining your testing approach - very reasonable one, I like it :D |
The changes proposed allow to switch schema for all connections rather than the only default database.
The changes assume that all connections are always on the same schema as the first connection (
'default'), meaning the tasks are not switching schema during their execution. Thus that we don't need to check all connections whether they are on a different schema or not.The lines where the assumption is made:
Solves #52