Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check-ping #280

Merged
merged 5 commits into from
Mar 26, 2019
Merged

Add check-ping #280

merged 5 commits into from
Mar 26, 2019

Conversation

a-know
Copy link
Contributor

@a-know a-know commented Mar 16, 2019

No description provided.

Copy link
Member

@lufia lufia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

"github.com/stretchr/testify/assert"
)

func TestIsIPv6(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@a-know a-know merged commit ddd2737 into master Mar 26, 2019
@a-know a-know deleted the check-ping branch March 26, 2019 05:16
@lufia lufia mentioned this pull request Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants