add --user to check-http #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for your contribution! You can also specify user info in urls like |
|
Hi,
i was not aware of this (as i tried to avoid this syntax since years), but
yes, you’re right.
One reason to keep user:pass separate from the url is the usage of the url
in notifications or the gui, where you probably don’t want to show login
credentials.
Gerhard
Von: Susisu [mailto:[email protected]]
Gesendet: Montag, 19. August 2019 05:10
An: mackerelio/go-check-plugins <[email protected]>
Cc: Gerhard Lausser <[email protected]>; Author
<[email protected]>
Betreff: Re: [mackerelio/go-check-plugins] add --user to check-http (#297)
Hi, thank you for your contribution!
You can also specify user info in urls like
https://user:[email protected]/, is this not preferable?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#297?email_source=notifications&email_token=AABQSOHSGOVSBZBRLDOZP4TQFIFKFA5CNFSM4IJZWPNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4RR5NI#issuecomment-522395317>
, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABQSOFNOSCX7QR423WOCG3QFIFKFANCNFSM4IJZWPNA>
.
<https://github.com/notifications/beacon/AABQSODOFEGICNWT5Y5TEW3QFIFKFA5CNFSM4IJZWPNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4RR5NI.gif>
|
susisu
reviewed
Aug 21, 2019
check-http/lib/check_http.go
Outdated
| @@ -32,6 +32,7 @@ type checkHTTPOpts struct { | |||
| MaxRedirects int `long:"max-redirects" description:"Maximum number of redirects followed" default:"10"` | |||
| ConnectTos []string `long:"connect-to" value-name:"HOST1:PORT1:HOST2:PORT2" description:"Request to HOST2:PORT2 instead of HOST1:PORT1"` | |||
| Proxy string `short:"x" long:"proxy" value-name:"[PROTOCOL://][USER:PASS@]HOST[:PORT]" description:"Use the specified proxy. PROTOCOL's default is http, and PORT's default is 1080."` | |||
| BasicAuth string `long:"user" description:"<user:password> Server user and password."` | |||
There was a problem hiding this comment.
I recommend using value-name tag, like value-name:"USER[:PASSWORD]".
|
@lausser Can you fix #297 (comment), please? |
|
Finally, after an hour of commits, rebase, squash and all that can go wrong :-)) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small improvement so you can check a website which requires basic auth. (i called it "--user" because that's how this parameter is called in curl)