migrate CIs to GitHub Actions #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'go vet' run automatically during 'go test'.
|
I have checked the workflow generates 9 packages and they will be uploaded at the next release. ref https://github.com/mackerelio/go-check-plugins/pull/432/checks?check_run_id=1471763258#step:6:920 |
|
|
shibayu36
approved these changes
Nov 30, 2020
.github/workflows/test.yml
Outdated
| with: | ||
| status: ${{ job.status }} | ||
| fields: repo,message,commit,action,eventName,ref,workflow,job,took | ||
| username: mkr-release |
There was a problem hiding this comment.
Is go-check-plugins-release correct?
.github/workflows/test.yml
Outdated
| @@ -29,7 +29,7 @@ jobs: | |||
| restore-keys: | | |||
| ${{ runner.os }}-go- | |||
| - run: | | |||
| make lint cover all | |||
There was a problem hiding this comment.
all task in Makefile may be erased?
There was a problem hiding this comment.
Sure, but I think make all is useful to run all tasks locally...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've migrate both Travis CI and AppVeyor tasks into a GitHub Actions workflow.
see mackerelio/mkr#339