Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strings.Replacer and strings.ReplaceAll where appropriate #667

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Use strings.Replacer and strings.ReplaceAll where appropriate #667

merged 1 commit into from
Jan 21, 2025

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Jan 9, 2025

I replaced some code using strings.Replace(..., -1) to use strings.Replacer and strings.ReplaceAll where they are more appropriate in my opinion.

@ne-sachirou ne-sachirou self-requested a review January 21, 2025 05:51
ne-sachirou
ne-sachirou approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@ne-sachirou ne-sachirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good refactoring

@ne-sachirou ne-sachirou merged commit cbc0ca3 into mackerelio:master Jan 21, 2025
12 checks passed
@mackerelbot mackerelbot mentioned this pull request Jan 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ne-sachirou ne-sachirou ne-sachirou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itchyny @ne-sachirou