Skip to content

Commit

Permalink
[chore] [cmd/mdatagen] Remove redis todo for missing units
Browse files Browse the repository at this point in the history
Now that open-telemetry#23573 has been merged, we can remove the todo.
  • Loading branch information
mackjmr committed Jul 19, 2023
1 parent 65e6596 commit e24e8af
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions cmd/mdatagen/validate.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,9 @@ func (md *metadata) validateMetrics() error {
"only one of the following has to be specified: sum, gauge", mn))
continue
}
// TODO: Remove once https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/23573 is merged.
if md.Type != "redis" {
if err := m.validate(); err != nil {
errs = multierr.Append(errs, fmt.Errorf(`metric "%v": %w`, mn, err))
continue
}
if err := m.validate(); err != nil {
errs = multierr.Append(errs, fmt.Errorf(`metric "%v": %w`, mn, err))
continue
}
unknownAttrs := make([]attributeName, 0, len(m.Attributes))
for _, attr := range m.Attributes {
Expand Down

0 comments on commit e24e8af

Please sign in to comment.